Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regex activation on invalid terms #30

Closed
bengreenier opened this issue Jan 19, 2018 · 1 comment
Closed

regex activation on invalid terms #30

bengreenier opened this issue Jan 19, 2018 · 1 comment
Assignees
@bengreenier
Labels
bug

Comments

@bengreenier
Copy link
Owner

We shouldn't be running preview code for terms that aren't require, or import, yet we see the following in latest vscode:

image
@bengreenier bengreenier self-assigned this Jan 19, 2018
bengreenier added a commit that referenced this issue Jan 21, 2018
@bengreenier
fix #30 - regex parsing bug 🐛 🔨
dac5c84
@bengreenier
Copy link
Owner Author

bengreenier commented Jan 21, 2018 •
edited
Loading

as part of fixing this issue, i noticed that ctrl+shift+r on an unsupported value no longer opens the module input popup, i'm going to fix that here as well

bengreenier referenced this issue Jan 21, 2018
@bengreenier
fix module input popup
450d2fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bengreenier bengreenier

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bengreenier