Made some modifications on the IOS implementation to unify behavior with Android’s one. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation into benjamindean-master
|
Thank you for the contribution! Could you, please, format the code so it's easier to see the diff? |
|
Yes, sorry about that was just happy I got it to work and forgot to clean the code! |
|
Thanks! I will try to test it as soon as I can. |
|
Any update? |
|
Hey @benjamindean ! Just saw that you've been worked on this project recently 😁 |
|
Hey! Yeah, I guess I cn safely merge it now. Thanks for notifying! |
|
Will release a new version as soon as the web implementation is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only thing not working now on iOS is the vibration without Amplitude (only pattern). I unfortunately don’t have access to iOS hardware anymore so cannot implement that.
Amplitudes is confirmed to work and the test app works similarly on iOS and Android.