Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation instances distinction #129

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

piomar123
Copy link
Contributor

Making it clear that formatters & console can be accessed only from static module. Relases issue #106

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just a little cleanup to make the naming consistent would be great! Apologies for the delayed response.

@Methuselah96
Copy link
Collaborator

Methuselah96 commented Aug 24, 2023

Looks like there are merge conflicts, but otherwise good to go! Thanks!

Making it clear that formatters & console can be accessed only from static module. Issue benjamine#106
Co-authored-by: Nathan Bierema <nbierema@gmail.com>
@piomar123
Copy link
Contributor Author

Resolved conflicts, waiting for CI build

Co-authored-by: Nathan Bierema <nbierema@gmail.com>
@Methuselah96
Copy link
Collaborator

Thanks! Sorry for the back-and-forth for such a simple change. 😄

@Methuselah96 Methuselah96 merged commit 371ab1a into benjamine:master Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants