Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify language and footer meta menu: Use list-inline instead of custom styles #1460

Conversation

SventB
Copy link
Contributor

@SventB SventB commented Jan 7, 2024

Pull Request

Prerequisites

  • Changes have been tested on TYPO3 v11.5 LTS
  • Changes have been tested on TYPO3 v12.4 LTS
  • Changes have been tested on PHP 7.4
  • Changes have been tested on PHP 8.0
  • Changes have been tested on PHP 8.1
  • Changes have been tested on PHP 8.2
  • Changes have been checked for CGL compliance php-cs-fixer fix
  • CSS has been rebuilt (only if there are SCSS changes cd Build; npm ci; npm run build)

Description

Simplifies language and footer meta menu by using Bootstrap class "list-inline" (nothing else is the language and footer meta menu right now) instead of custom styles.

Steps to Validate

Check language and footer meta menu.

@SventB SventB changed the title Simplify language menu: Use list-inline instead of custom styles Simplify language and footer meta menu: Use list-inline instead of custom styles Jan 7, 2024
@benjaminkott
Copy link
Owner

@SventB i understand where this demand is comming from. anyways i would like to keep certain elements to not use bootstrap at all to keep compat moving forward to avoid breaking on bootstrap updates. I still think this makes customizing more easy of we keep the styling seperate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants