Allow building types with .from using an object
#252
Conversation
|
Here's my first stab at implementing the |
|
Looking forward to reviewing this weekend! |
lib/types.js
Outdated
| // using field values from the passed object. For fields missing from the passed object, | ||
| // their default value will be used. | ||
| builder.from = function (obj) { | ||
| var built = Object.create(nodePrototype); |
There was a problem hiding this comment.
This object creation can come after the self.finalized check, though I guess the same could be said for the existing code in the builder function.
lib/types.js
Outdated
|
|
||
| Object.keys(self.allFields).forEach(function (param) { | ||
| // Use the default value. | ||
| addParam(built, param, null, false); |
There was a problem hiding this comment.
I think this loop also needs to check whether obj[param] is defined, so that obj can provide values for more than just the .build parameters, e.g.
builders.identifier.from({ name: "foo", typeAnnotation: ... })The typeAnnotation parameter isn't one of the .build parameters, but it seems like it should get checked and included, if provided.
There was a problem hiding this comment.
Ah, you're right. I think we don't even need to loop over self.buildParams either since any field in self.allFields could be specified in obj. Now updated.
With `.from`, you can be explicit about which fields you want to populate, without having to deal with the positional arguments of the normal builder. See also: facebook/jscodeshift#180 (comment)
With
.from, you can be explicit about which fields you want topopulate, without having to deal with the positional arguments
of the normal builder.
See also:
facebook/jscodeshift#180 (comment)