Restore whole-program parsing/validation tests, with necessary def updates and repository maintenance
#886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2022
eventualbuddha
approved these changes
Dec 11, 2022
package.json
Outdated
| "glob": "8.0.3", | ||
| "mocha": "^9.1.3", | ||
| "recast": "0.21.5", | ||
| "recast": "0.23.0-pr-1247", |
I am intentionally using the ^0.23.0 syntax here, even though other versions in devDependencies are exact (no ^), because recast has an exact dependency on ast-types. If there was an exact dependency in the other direction too, and the versions ever disagreed, multiple copies of these packages would need to be installed in nested node_modules directories, which is undesirable for many reasons.
These tests should be reporting an error according to output.json, but they both parse successfully. Possible clue: both tests have BABEL_8_BREAKING set to true in options.json.
benjamn
commented
Dec 11, 2022
Comment on lines
+36
to
+42
| if (files.length < 10) { | ||
| throw new Error(`Unexpectedly few **/input.ts files matched (${ | ||
| files.length | ||
| }) in ${ | ||
| babelTSFixturesDir | ||
| }`); | ||
| } |
Owner
Author
There was a problem hiding this comment.
Hopefully this check will prevent the scenario where the glob pattern suddenly fails to match any files (such as the upstream project deciding to bulk-rename all the input.ts files).
benjamn
added a commit
that referenced
this pull request
Dec 11, 2022
This minor version includes a major reorganization of the repository/package, which took place mostly in PR #327, with additional refinements in #886. There's always some risk to refactoring, and I added several new type definitions, hence the minor version bump. Why not a major version bump? I believe these changes should be mostly backwards compatible, especially if you are not importing from any nested directories like import es2020Plugin from "ast-types/def/es2020" Since the `def/` directory has moved to `lib/def/`, you may need to update your imports (a breaking change). However, you may be able to get away with no changes if you're using a version of Node.js (or a bundler) that understands the "exports" field in package.json: #327 (comment) Since I could be wrong about backwards compatibility, I will publish v0.16.0 to npm using the "next" dist-tag initially, so we can make sure benjamn/recast#1232 works. If breaking changes come to light, we should be able to fix them before triggering a flood of failing CI runs via dependabot/renovate/etc PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address @eventualbuddha's comment #327 (comment), though of course reenabling those whole-program parsing and validations tests meant fixing the ones that were failing.
There are still two tests failing when checkingSkipped! e0ae66east.errorsagainstexpected.errors. If I can't figure out what's going on with those test fixture files tomorrow, I'll just skip parsing/validating them.New definitions added:
TSInstantiationExpressionTSTypeCastExpressionTSSatisfiesExpressionClassAccessorProperty