Support optimistic.forget to remove Entry objects from Cache. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method takes the same arguments that optimistic.dirty and optimistic.peek take (TKeyArgs, as opposed to the full TArgs that the optimistic function itself takes). This distinction means you can remove entries as long as you have TKeyArgs, even if you don't have TArgs. Like Map.prototype.delete and friends, optimistic.forget returns a boolean to indicate whether an entry was deleted.
benjamn
force-pushed
the
optimistic.forget
branch
from
1cd60df to
b3e354e
Compare
benjamn
added a commit
that referenced
this pull request
Oct 13, 2020
The minor version bump is due to the (fully backwards-compatible) addition of the optimistic.forget method in #84.
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Oct 13, 2020
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method takes the same arguments as
optimistic.dirtyandoptimistic.peek(TKeyArgs, as opposed to the fullTArgsthat theoptimisticfunction itself takes). This distinction means you can remove entries as long as you haveTKeyArgs, even if you don't haveTArgs.Like
Map.prototype.deleteand friends,optimistic.forgetreturns a boolean to indicate whether an entry was deleted.This new API should enable a straightforward solution for apollographql/apollo-client#7149 and apollographql/apollo-client#7086.