Refactor `@wry/equality` to support custom `[deepEquals]` methods#230

Open

benjamn wants to merge 27 commits intomainfrom refactor-to-support-custom-deepEquals-methods

+631-208

Commits on Jan 21, 2022

Tailor array comparison logic to arrays.
benjamn
committed
Reject !== objects with custom prototypes.
benjamn
committed
Support a.equals(b) && b.equals(a) equality.
benjamn
committed
Pass check helper function to a.equals(b, check).
benjamn
committed
Switch to a more object-oriented DeepChecker#check style.
benjamn
committed
Extract DeepChecker and helper utilities into separate modules.
benjamn
committed
Rename hasEqualsMethod to isEquatable, matching Equatable<T>.
benjamn
committed
Decompose private DeepChecker#check{Array,Object,...}s helper methods.
benjamn
committed
Switch to a more functional style for check helpers.
benjamn
committed
Use Map rather than switch statement to look up check functions.
benjamn
committed
Test that objects with unusual prototypes are compared with ===.
benjamn
committed
Test that custom classes can define their own .equals methods.
benjamn
committed
Test class with unknown Symbol.toStringTag and .equals method.
benjamn
committed
Rename .equals method to .deepEquals.
benjamn
committed
Move Equatable interface and isEquatable function into helpers.ts.
benjamn
committed
Export DeepEqualsHelper type for second deepEquals parameter.
benjamn
committed
Test/fix cyclic structures with deepEquals methods.
benjamn
committed
Fix assertEqual error message typo.
benjamn
committed
Treat array holes the same as undefined elements.
benjamn
committed
Remove Node.js v10 from test rotation.
benjamn
committed
Trivial a === b shortcut for top-level equal(a, b) function.
benjamn
committed
Inline previouslyCompared logic into DeepChecker#check method.
benjamn
committed
Use unique Symbol instead of string "deepEquals" method.
benjamn
committed
Initialize members lazily to cheapen DeepChecker constructor.
benjamn
committed
Avoid expensive DeepChecker instance property initializations.
benjamn
committed
Optimize definedKeys a bit.
benjamn
committed
Shorten deepEqualsMethod name and export related helpers.
benjamn
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor `@wry/equality` to support custom `[deepEquals]` methods#230

Commits on Jan 21, 2022

Tailor array comparison logic to arrays.

Reject !== objects with custom prototypes.

Support a.equals(b) && b.equals(a) equality.

Pass check helper function to a.equals(b, check).

Switch to a more object-oriented DeepChecker#check style.

Extract DeepChecker and helper utilities into separate modules.

Rename hasEqualsMethod to isEquatable, matching Equatable<T>.

Decompose private DeepChecker#check{Array,Object,...}s helper methods.

Switch to a more functional style for check helpers.

Use Map rather than switch statement to look up check functions.

Test that objects with unusual prototypes are compared with ===.

Test that custom classes can define their own .equals methods.

Test class with unknown Symbol.toStringTag and .equals method.

Rename .equals method to .deepEquals.

Move Equatable interface and isEquatable function into helpers.ts.

Export DeepEqualsHelper type for second deepEquals parameter.

Test/fix cyclic structures with deepEquals methods.

Fix assertEqual error message typo.

Treat array holes the same as undefined elements.

Remove Node.js v10 from test rotation.

Trivial a === b shortcut for top-level equal(a, b) function.

Inline previouslyCompared logic into DeepChecker#check method.

Use unique Symbol instead of string "deepEquals" method.

Initialize members lazily to cheapen DeepChecker constructor.

Avoid expensive DeepChecker instance property initializations.

Optimize definedKeys a bit.

Shorten deepEqualsMethod name and export related helpers.