Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move root tsconfig.json into shared/ directory (fka scripts/) #478

Merged
merged 2 commits into from
May 4, 2023

Conversation

benjamn
Copy link
Owner

@benjamn benjamn commented May 3, 2023

The root wryware package isn't really a TypeScript package needing tsc compilation, so it doesn't need its own tsconfig.json file.

TypeScript/VSCode gave me repeated warnings about the top-level tsconfig.json file, which exists only to centralize shared options for the various packages/*/tsconfig.json files, so I moved it into a subdirectory, where it can still be imported by other tsconfig.json files, but shouldn't cause any errors/warnings for the wryware package itself.

@benjamn benjamn self-assigned this May 3, 2023
@benjamn benjamn merged commit 5d96777 into main May 4, 2023
@benjamn benjamn deleted the simplify-tsconfig.json-files branch May 4, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant