Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all occurences of "remove" to "close" #56

Open
benji300 opened this issue Nov 20, 2021 · 0 comments
Open

Change all occurences of "remove" to "close" #56

benji300 opened this issue Nov 20, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@benji300
Copy link
Owner

Tabs are closed, not removed. So change the wording everywhere.
The commands itself (e.g. tabsClear) shall not be renamed.

  • Check labels in code
  • Check README
@benji300 benji300 added the enhancement New feature or request label Nov 20, 2021
silopolis added a commit to silopolis/joplin-note-tabs that referenced this issue Jul 24, 2024
@silopolis
fix: change "remove" to "close"
9136796 
* rename `removeTab()` to `closeTab`
* Fix strings and comments wording

/closes Change all occurences of "remove" to "close" (benji300#56)
@silopolis silopolis mentioned this issue Jul 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benji300