Skip to content

Commit

Permalink
Fixes to release script post-pantsbuild#7235.
Browse files Browse the repository at this point in the history
Also fix some release-related documentation.
  • Loading branch information
benjyw committed Mar 10, 2019
1 parent 7036c50 commit 67d0b7c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions build-support/bin/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ py_major_minor_patch=$(${PY} -c 'import sys; print(".".join(map(str, sys.version
export PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS="${PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS:-['CPython==${py_major_minor_patch}']}"

function run_local_pants() {
${ROOT}/pants "$@"
${ROOT}/pants2 "$@"
}

# NB: Pants core does not have the ability to change its own version, so we compute the
Expand Down Expand Up @@ -483,7 +483,7 @@ function fetch_and_check_prebuilt_wheels() {
fi
done

if [ "${cross_platform}" != "true" ] && [ ${#packages[@]} -ne 2 ]; then
if [ "${cross_platform}" != "true" ] && [ ${#packages[@]} -ne 4 ]; then
missing+=("${NAME} (expected whls for each platform: had only ${packages[@]})")
continue
fi
Expand Down Expand Up @@ -590,7 +590,7 @@ function build_pex() {

execute_pex \
-o "${dest}" \
--script=pants \
--script=pants2 \
"${platform_flags[@]}" \
"${requirements[@]}"

Expand Down
2 changes: 1 addition & 1 deletion src/docs/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ is not required.
3. Publish to PyPi
------------------

Once the first two travis shards (the "binary builder" shards) have completed for your release
Once the four "Build wheels" Travis shards have completed for your release
commit, you can publish to PyPi. First, ensure that you are on your release branch at your version
bump commit. Then, publish the release:

Expand Down

0 comments on commit 67d0b7c

Please sign in to comment.