Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node package isn't currently importable #10

Open
deontologician opened this issue Jan 26, 2016 · 7 comments
Open

Node package isn't currently importable #10

deontologician opened this issue Jan 26, 2016 · 7 comments

Comments

@deontologician
Copy link

Right now it fails because the package.json specifies index.js as the main file, which doesn't exist. It also uses a global variable Rx, instead of requiring it so creating a simple index.js that points to one of the files in the dist/ directory doesn't work either.

I don't know what the best way of fixing this might be. I'd suggest requiring Rx directly, but I'm not familiar with Broccoli, so maybe there's some better way to handle this

@deontologician
Copy link
Author

Also getting this:

DEPRECATION: Brocfile.js has been deprecated in favor of ember-cli-build.js. Please see the transition guide: https://github.com/ember-cli/ember-cli/blob/master/TRANSITION.md#user-content-brocfile-transition.

@vidakovic
Copy link

+1

@jayphelps
Copy link

FYI this is mostly being neglected because major work has been going on for the new version of RxJS, v5. https://github.com/ReactiveX/rxjs (note: this is a totally different repo than https://github.com/Reactive-Extensions/RxJS)

So RxSocketSubject needs to be ported over to v5, and along the way needs to move away from Broccoli build to probably webpack. While I can't speak for @Blesh, since he's on my team I can guess that this upgrade isn't likely to happen by us until we really need it to happen; which we totally will, just not right now. That's the unfortunate reality of needing to prioritize the many things we juggle.

If someone is adventurous, PRs are, as always, welcome but we understand if no one can either.

@huan
Copy link

huan commented May 3, 2017

I'm looking for a good solution for RxJS-ed WebSocket this week, even want to write by myself if there's no good one meet my requirement.

Luckily I found RxSocketSubject here, it almost implemented everything I want, like:

  1. socket.subscribe()
  2. socket.next()
  3. auto-reconnect
  4. multiplexing
  5. etc.

However, it's still RxJS 4. I'd like to rewrite to RxJS 5 with TypeScript. If so, would you like to accept PR like this? Because I also like the npm module name rx-socket-subject. ;-)

Thanks for writing this awesome module! @benlesh @jayphelps Looking forward to your reply.

@deontologician
Copy link
Author

deontologician commented May 3, 2017 via email

@deontologician
Copy link
Author

deontologician commented May 3, 2017 via email

@huan
Copy link

huan commented May 4, 2017

@deontologician Wow, I will go to have a look on that.

thanks, buddy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants