Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to honor python imports rules for pex_binaries. #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srikalyan
Copy link

@srikalyan srikalyan commented Apr 10, 2017

bazelbuild/bazel#2791 should provide the imports information to skylark and this review uses that information (provided in skylark) to build pex_binaries that honor import.


This change is Reviewable

@srikalyan
Copy link
Author

I could not find a easy way to add this info for pex binary and other pex artifcats. If you could provide some tips, I can get it up and running

@benley
Copy link
Owner

benley commented Apr 10, 2017

Awesome, thank you for the pull request! I'm not sure I understand what you mean by "add this info for pex binary and other pex artifacts" - can you elaborate?

@benley benley self-assigned this Apr 10, 2017
@benley benley self-requested a review April 10, 2017 22:18
@srikalyan
Copy link
Author

This current implementation only supports pex_binary. Does not support imports for pex_library, pex_test, pex_pytest. Perhaps a pointer can definitely help me add that support.

@benley
Copy link
Owner

benley commented Apr 13, 2017

Sorry for the delay - I haven't forgotten about this, but I haven't had time to return to it just yet.

@benley
Copy link
Owner

benley commented Jun 27, 2017

I guess we're still waiting for bazelbuild/bazel#2791 to get merged...

@evanj
Copy link
Contributor

evanj commented Jan 8, 2018

This has the same motivation as #42 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants