Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to specify script attribute for pex #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mouadino
Copy link
Contributor

Sadly entrypoint isn't enough since not all scripts are tracked inside
python packages, e.g. ansible project have useful scripts like
ansible-playbook inside a folder called bin[1] that is not a python
package, hence we cannot use entrypoint for it.

[1] https://github.com/ansible/ansible/tree/devel/bin

Sadly entrypoint isn't enough since not all scripts are tracked inside
python packages, e.g. ansible project have useful scripts like
ansible-playbook inside a folder called bin[1] that is not a python
package, hence we cannot use entrypoint for it.

[1] https://github.com/ansible/ansible/tree/devel/bin
@benley
Copy link
Owner

benley commented Dec 19, 2017

This is very similar to what the main attribute does, but cleaner. How would you feel about changing the behavior of main so that acts like your new script attribute instead of its current (hacky) behavior? The way it translates filenames into python module/package names has always been a source of trouble, and it probably should have been done this way with --script all along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants