Fixed issue with custom template not working #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, this is the same changes as #19 which still doens't look like it will work, but I will go ahead and merge this one since it contains the distribution code as well. |
benmarch
added a commit
that referenced
this pull request
Jul 23, 2015
Fixed issue with custom template not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im not sure if this is correct but this is the only way i could get a custom template to work with boutstrap-tour and your directive. Apparently bootstrap-tour requires a template as a string however your directive is giving it an object and an error is occuring. Let me know if this is correct or if there is another way around this