Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot parse @deprecated JSDoc on file with line ending \r\n #1233

Closed
ljqx opened this issue Nov 16, 2018 · 1 comment · Fixed by #1234
Closed

Cannot parse @deprecated JSDoc on file with line ending \r\n #1233

ljqx opened this issue Nov 16, 2018 · 1 comment · Fixed by #1234
Labels
bug help wanted

Comments

@ljqx
Copy link
Contributor

ljqx commented Nov 16, 2018

The code in ExportMap explicitly requires the line ending to be \n, but it's not always true. On Windows, we have default line ending \r\n.
https://github.com/benmosher/eslint-plugin-import/blob/798eed7e559adab2eac07bf1b3e3518d4b7a4296/src/ExportMap.js#L233

I can send fix for this.
This was referenced Nov 16, 2018
Merged
Merged
@ljharb
Copy link
Member

ljharb commented Nov 16, 2018

Thanks, that'd be great.

ljharb pushed a commit to ljqx/eslint-plugin-import that referenced this issue Apr 11, 2019
@ljqx @ljharb
[ExportMap] fix condition for checking if block comment
e4850df 
Fixes import-js#1233.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ExportMap] fix condition for checking if block comment ljqx/eslint-plugin-import
2 participants
@ljharb @ljqx