[ExportMap] fix condition for checking if block comment

Fixes import-js#1233.
ljqx · Nov 16, 2018 · e4850df · e4850df
1 parent 918567d
commit e4850df
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/src/ExportMap.js b/src/ExportMap.js
@@ -243,7 +243,7 @@ function captureJsDoc(comments) {
   // capture XSDoc
   comments.forEach(comment => {
     // skip non-block comments
-    if (comment.value.slice(0, 4) !== '*\n *') return
+    if (comment.type !== 'Block') return
     try {
       doc = doctrine.parse(comment.value, { unwrap: true })
     } catch (err) {

diff --git a/tests/src/core/getExports.js b/tests/src/core/getExports.js
@@ -96,12 +96,12 @@ describe('ExportMap', function () {
 
   context('deprecation metadata', function () {
 
-    function jsdocTests(parseContext) {
+    function jsdocTests(parseContext, lineEnding) {
       context('deprecated imports', function () {
         let imports
         before('parse file', function () {
           const path = getFilename('deprecated.js')
-              , contents = fs.readFileSync(path, { encoding: 'utf8' })
+              , contents = fs.readFileSync(path, { encoding: 'utf8' }).replace(/[\r]\n/g, lineEnding)
           imports = ExportMap.parse(path, contents, parseContext)
 
           // sanity checks
@@ -191,7 +191,15 @@ describe('ExportMap', function () {
           attachComment: true,
         },
         settings: {},
-      })
+      }, '\n')
+      jsdocTests({
+        parserPath: 'espree',
+        parserOptions: {
+          sourceType: 'module',
+          attachComment: true,
+        },
+        settings: {},
+      }, '\r\n')
     })
 
     context('babel-eslint', function () {
@@ -202,7 +210,15 @@ describe('ExportMap', function () {
           attachComment: true,
         },
         settings: {},
-      })
+      }, '\n')
+      jsdocTests({
+        parserPath: 'babel-eslint',
+        parserOptions: {
+          sourceType: 'module',
+          attachComment: true,
+        },
+        settings: {},
+      }, '\r\n')
     })
   })