Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderToNodeStream -> renderToStream #1

Closed
wants to merge 2 commits into from
Closed

renderToNodeStream -> renderToStream #1

wants to merge 2 commits into from

Conversation

magicmark
Copy link

Hi,

Thanks for the awesome talk at React Rally! 👏 😃

I was playing around with the new version of react-dom (16.0.0-beta.5) to try and use the streaming API, following your example.

Although the API used will be correct soon (facebook/react#10425), the current @next release (16.0.0-beta.5) appears to still use the old API.

(Probably not be worth merging if it's being released soon - just mentioning it in case someone else runs into this for now.)

Thanks again!

renderToNodeStream -> renderToStream
@benmvp
Copy link
Owner

benmvp commented Aug 28, 2017

Thanks! Glad you enjoyed it! 😃

So yeah, I had the original code you've just suggested, and then stumbled upon the commit you linked to. I figured it would be better to have the newest API, but you're right that the latest beta still has the old API. I should've just mentioned the change, but totally forgot!

I think I'll leave it, but thanks for the call out! How'd the streaming turn out for you?

@magicmark
Copy link
Author

magicmark commented Aug 28, 2017

@benmvp Got it working great, thanks!

https://github.com/magicmark/personal-website-v2/blob/master/src/server.js#L39 👌

Fun to play around with. Interesting to see how we'll take advantage of this in production.

@magicmark magicmark closed this Aug 28, 2017
@benmvp
Copy link
Owner

benmvp commented Aug 28, 2017

Niiiiiice!

BTW - I'm still super impressed that you were able to find this repo and make the fix. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants