squid:S1319 - Declarations should use Java collection interfaces such… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as List rather than specific implementation classes such as LinkedList
|
I am not sure whether you do not agree with these changes or not. Please close this PR if not. |
|
I just see this right now, so sorry. I also use the Map before, I looked at the Android performance advice directly using the class object is faster than the interface. Statement HashMap map is more efficient than Map map, even if both are HashMap. About 6% of the performance loss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule squid:S1319 - Declarations should use Java collection interfaces such as List rather than specific implementation classes such as LinkedList
You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:1319
Please let me know if you have any questions.
M-Ezzat