feat: Ability to get withdrawal fee estimate #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already a FeeEstimate class.
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 483 486 +3
Branches 30 30
=========================================
+ Hits 483 486 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Great contribution! I just fixed the URL to Fee Estimate. Green light for merging if you are okay with it? |
bennycode
approved these changes
Oct 22, 2020
|
Go ahead 😄 |
|
It's now released with v2.13.0. I also changed the default branch to "main". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
/widthdrawals/fee-estimateresource.See: https://docs.prime.coinbase.com/#fee-estimate