Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement hmac authentication for create-* and sign-* endpoints #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rorp
Copy link
Contributor

@rorp rorp commented Dec 26, 2024

This PR introduces a simple out-of-the-box HMAC authentication and authorization scheme for write operations, which are currently wide open.

It introduces a non-optional KORMIR_HMAC_SECRET environment variable to define an HMAC secret. Authentication can be disabled by setting the KORMIR_HMAC_SECRET environment variable to none.

The server expects the client to send a hex-encoded HMAC signature, generated using the same secret, in the X-Signature HTTP request header.

@bennyhodl
Copy link
Owner

Thanks! #26 will fix the CI issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants