Update README.rst #275
Update README.rst #275
Conversation
|
Good catch! Probably don't even need to keep around the old style anymore, since nothing older than Django 3 is supported. Maybe ditch this part altogether: https://github.com/bennylope/django-organizations/pull/275/files#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168fR169-R180 And just keep the updated syntax block: https://github.com/bennylope/django-organizations/pull/275/files#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168fR184-R194 |
|
Noob level: I had no idea my PR was going to go to the parent repo. I thought that was just to update my fork, however, I'm glad to drop the v1 syntax and update the request.
|
Removed v1 references and expected imports
| @@ -172,8 +172,8 @@ main application URL conf as well as your chosen invitation backend URLs: | |||
There was a problem hiding this comment.
| from django.urls import path, include | |
There was a problem hiding this comment.
Sorry @satcomjimmy I did a bad job describing what I was suggesting. I think it's a great idea to still include this line!
There was a problem hiding this comment.
What do you think @bennylope?
There was a problem hiding this comment.
I likely have some more edits to suggest in the future, so I can add it back on a future PR
No description provided.