fix: added missing dependencies #146, #166

bennymeg · May 17, 2022 · d37a7bd · d37a7bd
1 parent da1af7b
commit d37a7bd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -16,8 +16,6 @@
   },
   "private": true,
   "devDependencies": {
-    "@angular-devkit/core": "^13.3.4",
-    "@angular-devkit/schematics": "^13.3.4",
     "@nrwl/angular": "13.10.3",
     "@nrwl/cli": "13.10.3",
     "@nrwl/devkit": "13.10.3",

diff --git a/packages/nx-electron/package.json b/packages/nx-electron/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nx-electron",
-  "version": "13.1.0",
+  "version": "13.1.1",
   "main": "src/index.js",
   "description": "Electron Plugin for Nx",
   "author": "Benny Megidish",
@@ -46,10 +46,14 @@
     "executors"
   ],
   "peerDependencies": {
-    "@nrwl/workspace": "^13",
     "electron": "*"
   },
   "dependencies": {
+    "@angular-devkit/schematics": "^13",
+    "@nrwl/devkit": "^13",
+    "@nrwl/jest": "^13",
+    "@nrwl/linter": "^13",
+    "@nrwl/workspace": "^13",
     "circular-dependency-plugin": "^5.2.2",
     "copy-webpack-plugin": "^10.2.4",
     "electron-builder": "^22.14.13",

diff --git a/packages/nx-electron/src/utils/electron.config.ts b/packages/nx-electron/src/utils/electron.config.ts
@@ -1,4 +1,4 @@
-import { appRootPath } from '@nrwl/tao/src/utils/app-root';
+import { workspaceRoot } from '@nrwl/devkit';
 import { Configuration } from 'webpack';
 import { merge } from 'webpack-merge';
 import nodeExternals from 'webpack-node-externals';
@@ -51,7 +51,7 @@ function getElectronPartial(options: BuildElectronBuilderOptions): Configuration
   }
 
   if (options.externalDependencies === 'all') {
-    const modulesDir = `${appRootPath}/node_modules`;
+    const modulesDir = `${workspaceRoot}/node_modules`;
     webpackConfig.externals = [nodeExternals({ modulesDir })];
   } else if (Array.isArray(options.externalDependencies)) {
     webpackConfig.externals = [