Skip to content

Commit

Permalink
feat(package): add option for overriding make options file
Browse files Browse the repository at this point in the history
Sometimes the make options should have different config. e.g. environment or alfa/beta testing icons
  • Loading branch information
narektutikian committed Oct 6, 2021
1 parent ab1d075 commit d569054
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/builders/package/package.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export interface PackageElectronBuilderOptions extends Configuration {
sourcePath: string;
outputPath: string;
publishPolicy?: PublishOptions["publish"];
makerOptionsPath?: string;
}

export interface PackageElectronBuilderOutput extends BuilderOutput {
Expand Down Expand Up @@ -164,6 +165,7 @@ function _createConfigFromOptions(options: PackageElectronBuilderOptions, baseCo
delete config["publishPolicy"];
delete config.sourcePath;
delete config.outputPath;
delete config["makerOptionsPath"];

return config;
}
Expand All @@ -182,7 +184,10 @@ function _normalizeBuilderOptions(targets: Map<Platform, Map<Arch, string[]>>, c

function mergePresetOptions(options: PackageElectronBuilderOptions): PackageElectronBuilderOptions {
// load preset options file
const externalOptionsPath: string = join(options.root, options['sourceRoot'], 'app', 'options', 'maker.options.json');
let externalOptionsPath: string = join(options.root, options['sourceRoot'], 'app', 'options', 'maker.options.json');
if (options.makerOptionsPath) {
externalOptionsPath = options.makerOptionsPath
}

if (statSync(externalOptionsPath).isFile()) {
const rawData = readFileSync(externalOptionsPath, 'utf8')
Expand Down
4 changes: 4 additions & 0 deletions src/builders/package/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@
"type": "string",
"enum": ["onTag", "onTagOrDraft", "always", "never"],
"description": "Package publish policy."
},
"makerOptionsPath": {
"type": "string",
"description": "Overrides the {sourceRoot}/app/options/maker.options.json path."
}
},
"required": ["name", "frontendProject"]
Expand Down

0 comments on commit d569054

Please sign in to comment.