Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 beta cant make or package #135

Closed
Gerolmed opened this issue Jan 25, 2022 · 6 comments
Closed

12 beta cant make or package #135

Gerolmed opened this issue Jan 25, 2022 · 6 comments

Comments

@Gerolmed
Copy link

Describe the bug
When running both package or make it complains about this:

 ERROR  Executor "nx-electron:package" should return either a Promise or an AsyncIterator

Im using beta.3 and nx 12.10.1

@bennymeg
Copy link
Owner

I don't understand from that came from, but I've fixed it.
Kindly verify that everything works properly for you as well.

@jakubwsternum
Copy link

jakubwsternum commented Jan 27, 2022

@bennymeg the build/package itself works, but it does not include the index.html from a frontend project (using nx react default package) in the app.asar file after packaging, the contents of app.asar differ for dist/packages/win-unpacked/resources directory and for the app.asar that is installed into the system by electron binary in C:\Users\USERNAME\AppData\Local\Programs\APPNAME\resources, the latter has filenames without hashes and html files are absent

EDIT: the missing --baseHref=./ option was the culprit here, so it is working :)

@Gerolmed
Copy link
Author

Gerolmed commented Jan 29, 2022

Seems to be building now, but the app isnt actually running properly. (Not even the electron code)

The image below shows the two windows (left == dev, right == exe). At least the electron code hiding the top bar should be working right?

Is there a way to see the logs? Ive tried to run the exe via console, but its not logging anything.

image

@bennymeg
Copy link
Owner

Everything works fine on my end.
Activate the developer tools window mainWindow.webContents.openDevTools(); and check out the logs.

@Gerolmed
Copy link
Author

It seems that it can't find the files. Im also using Vue https://github.com/ZachJW34/nx-plus/tree/master/libs/vue which might be the issue.
image

@Gerolmed
Copy link
Author

Gerolmed commented Jan 31, 2022

Nvm Im quite stupid forgot changing the base ref on build for the frontend. Now its working :D
Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants