We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug when we install the electron-builder package it will overwrite existing postinstall scripts in package.json
postinstall
package.json
To Reproduce
npx create-nx-workspace --name=nx-electron-tmp --preset=empty --appName=app --nx-cloud=0
cd nx-electron-tmp/
"postinstall": "echo existing-postinstall"
npm install -D nx-electron
nx g nx-electron:app
Expected behavior the installation should only append to an existing postinstall script
e.g. "postinstall": "echo existing-postinstall && exitzero electron-builder install-app-deps"
"postinstall": "echo existing-postinstall && exitzero electron-builder install-app-deps"
Desktop (please complete the following information):
Windows 10 64-bit
11.1.1
Additional context This is a minor issue, because it is usually easy to see the changes when we commit to git.
The text was updated successfully, but these errors were encountered:
b3a8846
fix: update post install script instead of overwriting it. closes #97
de69c98
No branches or pull requests
Describe the bug
when we install the electron-builder package it will overwrite existing
postinstall
scripts inpackage.json
To Reproduce
npx create-nx-workspace --name=nx-electron-tmp --preset=empty --appName=app --nx-cloud=0
cd nx-electron-tmp/
package.json
: e.g."postinstall": "echo existing-postinstall"
npm install -D nx-electron
nx g nx-electron:app
this will overwrite any previous postinstall scripts
Expected behavior
the installation should only append to an existing postinstall script
e.g.
"postinstall": "echo existing-postinstall && exitzero electron-builder install-app-deps"
Desktop (please complete the following information):
Windows 10 64-bit
11.1.1
Additional context
This is a minor issue, because it is usually easy to see the changes when we commit to git.
The text was updated successfully, but these errors were encountered: