Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation should keep existing postinstall scripts #97

Closed
tmtron opened this issue May 26, 2021 · 0 comments
Closed

installation should keep existing postinstall scripts #97

tmtron opened this issue May 26, 2021 · 0 comments

Comments

@tmtron
Copy link

tmtron commented May 26, 2021

Describe the bug
when we install the electron-builder package it will overwrite existing postinstall scripts in package.json

To Reproduce

  1. create nx workspace project: npx create-nx-workspace --name=nx-electron-tmp --preset=empty --appName=app --nx-cloud=0
  2. cd nx-electron-tmp/
  3. add a postinstall script to package.json: e.g. "postinstall": "echo existing-postinstall"
  4. install nx-electron: npm install -D nx-electron
  5. create nx-electron app: nx g nx-electron:app
    this will overwrite any previous postinstall scripts

Expected behavior
the installation should only append to an existing postinstall script

e.g. "postinstall": "echo existing-postinstall && exitzero electron-builder install-app-deps"

Desktop (please complete the following information):

  • OS: Windows 10 64-bit
  • Nx Electron Version : 11.1.1

Additional context
This is a minor issue, because it is usually easy to see the changes when we commit to git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant