Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move workspace to dev dependency #69

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

ericwooley
Copy link
Contributor

With nx 11, there is an error about cyan something arather.

tengable on ξ‚  auto-hide-sound [$!?] is πŸ“¦ v0.0.0 via β¬’ v14.14.0 on 🐳 v20.10.1 using ☁️  default/bubbles-298018 took 17s 
➜ nx build tengable-electron --skip-nx-cache

> nx run tengable-electron:build 
Unable to resolve nx-electron:build.
Cannot read property 'cyan' of undefined

I traced it down to @nrwl/workspace being in ^10.x.x the dependencies. Since there is an entry of * for peer dependencies, I assume that locking the workspace to version 10 is not intentional.

After fixing this, I am able to run the build and make builders.

which solves the second part of #66

@ericwooley
Copy link
Contributor Author

This makes everything work in my project, which was migrated from 9 to 11.

However, following the instructions on #66 then running nx build electron-test, outputs the error:

nx run test-electron:build 
Invalid format version detected - Expected:[ 1 ] Found: [ 2 ]

Asked about this in the nx slack

I suspect these dependencies need to be upgraded:

    "@angular-devkit/architect": "^0.1100.5",
    "@angular-devkit/build-webpack": "^0.1100.5",
    "@angular-devkit/core": "^11.0.5",
    "@angular-devkit/schematics": "^11.0.5",
    "@nrwl/jest": "^11.0.20",
    "@nrwl/linter": "^11.0.20"
    //...
   // dev deps
   "@nrwl/workspace": "^11.0.20"

However, when I upgrade them all the tests start failing. πŸ€·β€β™‚οΈ

I'm not that good with RX or with the angular devkit etc... and I don't have time to keep debugging :(

Hopefully this gets you a jumpstart though.

@bennymeg
Copy link
Owner

bennymeg commented Jan 4, 2021

Tnx, you are right, @nrwl/workspace should not be a dependency (that's why it was also a peer dependency).
As for v11, I will work on it after I will release v10, everything you said needed to be updated (and more).

@bennymeg bennymeg merged commit bfd8ec3 into bennymeg:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants