Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .pytest_cache #1762

Merged
merged 2 commits into from
May 7, 2018
Merged

Ignore .pytest_cache #1762

merged 2 commits into from
May 7, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Apr 28, 2018

Pytest now uses a .pytest_cache directory. Ignore it.

The default cache directory has been renamed from .cache to .pytest_cache after community feedback that the name .cache did not make it clear that it was used by pytest. (#3138)

https://docs.pytest.org/en/latest/changelog.html#pytest-3-4-0-2018-01-30

@berkerpeksag
Copy link
Collaborator

Thanks for the PR, but we usually prefer keeping things like this in a user's own global .gitignore file. We have cleaned up our .gitignore file to encourage people to use a global one in commit 4185b2b.

@tilgovi
Copy link
Collaborator

tilgovi commented Apr 28, 2018

In this case, pytest is in use by the project and it's not user specific. I'd be fine with this.

@berkerpeksag
Copy link
Collaborator

@tilgovi fine by me, I don't have a strong objection. I already added it to my own global .gitignore file since I use pytest in multiple projects.

@tilgovi tilgovi reopened this May 7, 2018
@tilgovi tilgovi merged commit 587dc63 into benoitc:master May 7, 2018
@tilgovi
Copy link
Collaborator

tilgovi commented May 7, 2018

Merged it :). Thanks.

@hugovk hugovk deleted the ignore-.pytest_cache branch May 7, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants