Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on_stopping hook to set anything before master is killed #3181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ilpianista
Copy link

As suggested in #2944. My use case is to postpone the shutdown of gunicorn.

@ilpianista ilpianista force-pushed the feature/on-stopping-hook branch from 6c5dac3 to 01cb7df Compare April 3, 2024 10:25
@ilpianista
Copy link
Author

@benoitc may you have a look at this please? Thanks

@pajod
Copy link
Contributor

pajod commented Aug 13, 2024

Design consideration: Whether the

  • failure of this hook should be full responsibility of the hook author (more flexible, wrapping try-except if so desired), or whether
  • failure of this hook should be ignored, shutdown proceeding anyway (similar to post_request() hook, within which exceptions are not treated as fatal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants