Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close open resources #3250

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Close open resources #3250

wants to merge 4 commits into from

Commits on Jul 25, 2024

  1. Close a temporary file acting as a fake socket 

    This resolves a `ResourceWarning` caused by the test suite.
    @kurtmckee
    kurtmckee committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    49618be View commit details
    Browse the repository at this point in the history

  2. Close open sockets when an exception is encountered

    @kurtmckee
    kurtmckee committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    62530ef View commit details
    Browse the repository at this point in the history

  3. Close open files to prevent ResourceWarning in the test suite

    @kurtmckee
    kurtmckee committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    dc197ff View commit details
    Browse the repository at this point in the history

  4. Escalate warnings to errors during testing 

    This ensures that unclosed resources will be caught in CI
    @kurtmckee
    kurtmckee committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7756175 View commit details
    Browse the repository at this point in the history