Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use infinity as default timeout #219

Closed
RJ opened this issue Jul 27, 2015 · 5 comments
Closed

Don't use infinity as default timeout #219

RJ opened this issue Jul 27, 2015 · 5 comments

Comments

@RJ
Copy link
Contributor

RJ commented Jul 27, 2015

There is a default 'infinity' recv_timeout in hackney:request

infinity makes a poor default, imo.

@edgurgel
Copy link
Collaborator

Interesting that I got a similar comment on HTTPoison edgurgel/httpoison#64

@benoitc
Copy link
Owner

benoitc commented Jul 29, 2015

It's now set to 5s :) Not sure right now what is the best value for it.

@benoitc
Copy link
Owner

benoitc commented Jul 29, 2015

Also in the next version it shouldn't freeze anymore the pool.

@RJ
Copy link
Contributor Author

RJ commented Jul 30, 2015

@benoitc great :)
did you make another change related to the pool freezing, or are you just referring to the default timeout?

for the record, we started seeing connections (to s3) hanging indefinitely after upgrading from 0.13.0 to 1.1.0

@benoitc
Copy link
Owner

benoitc commented Jul 30, 2015

Pool locking will be handled in the next release. Basically there won't be
any locking or freezing waiting for a connection to be released. Instead we
will only make sure to maintain a max of reused connection with a maximum
time given to a connection to be kept alive. This version will be available
sometimes this week.

On Thu, Jul 30, 2015 at 1:27 PM Richard Jones notifications@github.com
wrote:

@benoitc https://github.com/benoitc great :)
did you make another change related to the pool freezing, or are you just
referring to the default timeout?

for the record, we started seeing connections (to s3) hanging indefinitely
after upgrading from 0.13.0 to 1.1.0


Reply to this email directly or view it on GitHub
#219 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants