removing extra CRLF at the start of buffer before passing it to parse_headers
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a `<<"\r\b">>` at the beginning of the buffer passed to `parse_headers/1` prevented parser to correctly parsing headers. It is correctly deleted when handling response headers (in line 194).
|
Patch looks good. Do you have any code that could help to test it? Eventually some eunit that we could add? |
|
I'll write some tests. Since submitting this patch I fixed another bug in parsing requests on a presistant connection. I will add a bunch of tests for both these cases in |
|
ca you send me a PR with the changes above. Maybe we could add your patches in the coming release today? |
benoitc
added a commit
that referenced
this pull request
Apr 7, 2015
removing extra CRLF at the start of buffer before passing it to `parse_headers`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a
<<"\r\b">>at the beginning of the buffer passed toparse_headers/1prevented parser from correctly parsing headers. It is correctly deleted when handling responses. (see line 194 ofsrc/hackney_lib/hackney_http.erl)