Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-21296 edits #7

Merged
merged 12 commits into from
Apr 6, 2022
Merged

CHE-21296 edits #7

merged 12 commits into from
Apr 6, 2022

Conversation

deerskindoll
Copy link
Collaborator

Read our Contribution guide before submitting a PR.

What does this PR do?

Edited version of https://github.com/benoitf/che-docs/tree/CHE-21296

What issues does this PR fix or reference?

Edits of https://github.com/benoitf/che-docs/tree/CHE-21296

Specify the version of the product this PR applies to.

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Click here to review and test in web IDE: Contribute

deerskindoll and others added 10 commits April 6, 2022 11:30
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Copy link
Owner

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, waiting for comments being integrated into the document. Thanks

@deerskindoll
Copy link
Collaborator Author

Comments integrated.

@benoitf benoitf merged commit 0791149 into benoitf:CHE-21296 Apr 6, 2022
@deerskindoll deerskindoll deleted the patch-1 branch June 30, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants