Skip to content

Commit

Permalink
fix(convert): When converting devfile v1 to v2, registryUrl attribute…
Browse files Browse the repository at this point in the history
… is forgotten

Related to eclipse-che/che#19829

Change-Id: Ia7dd9aec31f0c6b5326c4d645bfbf4f87ac8e69e
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
  • Loading branch information
benoitf committed May 26, 2021
1 parent 9b7e3fe commit a7499e7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@ export class CheServerDevfileServiceImpl implements DevfileService {
if (componentV1.reference) {
devfileV2Component.plugin.url = componentV1.reference;
}
if (componentV1.registryUrl) {
devfileV2Component.plugin.registryUrl = componentV1.registryUrl;
}

if (componentV1.cpuLimit) {
devfileV2Component.plugin.cpuLimit = componentV1.cpuLimit;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ projects:
components:
- type: chePlugin
id: golang/go/latest
registryUrl: https://my-registry.fake
alias: go-plugin
memoryLimit: 512Mi
env:
Expand Down

0 comments on commit a7499e7

Please sign in to comment.