Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change background color on load to black #14

Conversation

Nik-Pavlov
Copy link

My humble attempt to fix a white screen while the app is loading. I use the app before bed sometimes and the white startup screen is not very comfortable.

@benoitletondor
Copy link
Owner

Hey @Nik-Pavlov ,

Thank you so much for your input, I know I took a while to answer but be sure that your PR has been received and I really appreciate it.

I'm actually thinking about it because there's no perfect solution to the problem :

  • Right now, if you're using Android 10 the launch screen takes the appropriate color depending on your OS theme (dark or light). It's not related to your in app choice though.
  • If we apply an always dark launch screen on Android < 10 (what your PR does), it's not the right choice if you're using the app on a light theme
  • If we apply an always white launch screen on Android < 10 (what your PR actually tries to fix), it's not the right choice if you're using the app on a dark theme

So I'm still not decided about what what to do here, but I guess your solution works better in every cases..

@Nik-Pavlov
Copy link
Author

Hi @benoitletondor,
Thank you very much for the quick response. I completely agree with all of your points. The second point about the inconsistency of launching with a black screen then immediately switching back to the white background - that point was bothering me the most when I was suggesting these changes.
But, in my opinion, watching at a black screen for some time at daylight is not so harmful as to be blinded by a bright white loading screen in the dark.

@benoitletondor
Copy link
Owner

I agree, I'll have to chance some of your code as I already have a dark theme background color, and I also think I have to apply the AppTheme to all the activities, not just the main one. But I definitely appreciate your help and it's a nice addition.

@benoitletondor
Copy link
Owner

Hey @Nik-Pavlov

Just wanted to let you know that I included your contribution, it will be part of the next update. I didn't merge it directly because it needed some work but those 2 commits are for you:

Thank you again :)

@Nik-Pavlov
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants