Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawl images and other HTML linked resources as well #103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dramalho
Copy link

@dramalho dramalho commented Jan 4, 2024

A small follow up to #102 where I was trying to figure out the best strategy to include ActiveStorage attachments into the static build.

TL;DR; I first tried to generate and copy the attachment files via a rake task but there are - to the best of my present knowledge - quite a few hoops to jump through to get the right final URL so that it matches what the markup expects, so much so that I think it's extremely error prone. The other option I explored was for parklife to merely collect more URLs and - maybe - get and save those files, which I ended up doing in Utils#scan_for_links

The code is simple enough but I'm unsure what scenarios exist that might hamper this approach, so I though I would open a PR just the same as that makes discussion easier .. maybe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant