Replaced go-bindata with go1.16's embed feature #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I am the submitter of this pull request. I can see the azure-pipeline CI check failures. |
|
Hey - thanks for the PR! I'll try and figure out the build failure, the image should have Go 1.16 but it's not the default. Once that's fixed this PR looks good to merge. |
mixcode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.16 introduced a language built-in file embedding feature, 'go embed'.
This patch replaces the use of go-bindata with go-embed regarding the systray icon.
By this change, the 'go generate' stage could be removed from the build process; hence the package would be directly installable with 'go install' command.