fix strict_loading_by_default in BaseRecord (#1475)

* Including executions in show controller * Disabling strich_loading_by_default for all GoodJob models * Including executions association in jobs_controller#show
bensheldon · Aug 29, 2024 · 0e3d094 · 0e3d094
1 parent 43ec2ad
commit 0e3d094
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/controllers/good_job/jobs_controller.rb b/app/controllers/good_job/jobs_controller.rb
@@ -61,7 +61,7 @@ def mass_update
     end
 
     def show
-      @job = Job.includes_advisory_locks.find(params[:id])
+      @job = Job.includes(:executions).includes_advisory_locks.find(params[:id])
     end
 
     def discard

diff --git a/app/models/good_job/base_record.rb b/app/models/good_job/base_record.rb
@@ -7,6 +7,7 @@ module GoodJob
   #   class BaseRecord < ActiveRecord::Base; end
   class BaseRecord < ActiveRecordParentClass
     self.abstract_class = true
+    self.strict_loading_by_default = false
 
     def self.migration_pending_warning!
       GoodJob.deprecator.warn(<<~DEPRECATION)