Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buggy theme animation while switching tabs #1224

Closed
AbhayVAshokan opened this issue Jan 23, 2024 · 6 comments · Fixed by #1298
Closed

Buggy theme animation while switching tabs #1224

AbhayVAshokan opened this issue Jan 23, 2024 · 6 comments · Fixed by #1298

Comments

@AbhayVAshokan
Copy link

flaky-theme-animation

Link: goodjob-demo.herokuapp.com/
Arc Browser: Version 1.25.1 (45028) Chromium Engine Version 120.0.6099.216
OS: macOS 14.2.1 (23C71) M1

@bensheldon
Copy link
Owner

Thanks for reporting! That looks bad. I can look into that unless you have a theory already.

@bensheldon
Copy link
Owner

hmmm, I'm having trouble reproducing this.

  • Does that happen on any link navigation or just when using the tabbed navbar?
  • Am I correct in assuming that your operating system is in Dark Mode, and you've set the Dashboard to light mode? (maybe that's related to the problem, though I think that shouldn't have a flash either)

@AbhayVAshokan
Copy link
Author

  1. It happens for every link navigation
  2. Correct.

Every navigation reloads the entire website. It briefly defaults to theme="auto" before going to theme="light".
theme

@bensheldon
Copy link
Owner

Note to self: maybe related twbs/bootstrap#39224

@carlosmintfan
Copy link

@bensheldon From a quick look, I think that isn't related because it only fixes an edge case for light OSes with "default" color mode. Anyway, make sure that the color-modes.js is included BEFORE the bootstrap CSS/JS (not only before the bootstrap js, but even before the bootstrap css) to make sure that color modes classes are applied to the page DOM before Bootstrap CSS styles it.

@carlosmintfan
Copy link

Note to self: maybe related twbs/bootstrap#39224

Ah, yeah, related if it defaults to auto...but anyway we have a fix now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants