Invoke inline Bootstrap Color Mode javascript above CSS link tag to better avoid flash of un-themed content #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
💖 I think this will be an improvement. Though I think there will be no way to entirely prevent a flash: twbs/bootstrap#37774 |
|
I guess the way to entirely avoid this would be to store the value in a server-readable cookie so that the value could be inserted into the html server-side, rather than done entirely in JS in the frontend. |
bensheldon
changed the title
bensheldon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1224
Big thank you to @carlosmintfan for pointing out the change.