-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifier errored: ArgumentError: wrong number of arguments (given 1, expected 0) #1280
Comments
You're hitting a bug in Rails described here: #785 (comment) Solution is to upgrade to Rails 6.1.8 👍 |
Aha, thanks for the tip! Unfortunately, per the discussion in the Rails PR,
Sounds like 6.1.8 might not be coming to the rescue, so it sounds like myself (and others who encounter this) will need to either monkey patch or figure out how to point Rails at an unreleased branch. 😬 And actually, as I look at the 6-1 stable branch, I don't see any commits since 6.1.7.7. And the PR that fixes the issue touches several files, so making a monkey patch would be pretty painful. Not sure how to proceed. |
Fortunately a version has been released since that comment was made.
…--
Ben Sheldon
***@***.***
On Mar 10, 2024 at 11:37 AM -0700, Bill Harding ***@***.***>, wrote:
Aha, thanks for the tip! Unfortunately, per the discussion in the Rails PR,
> No we are not going to release a 6.1.8, you can point your application at the 6-1-stable branch or upgrade to 7.0.x.
Sounds like 6.1.8 might not be coming to the rescue, so it sounds like myself (and others who encounter this) will need to either monkey patch or figure out how to point Rails at an unreleased branch. 😬
—
Reply to this email directly, view it on GitHub or unsubscribe.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Hmm, yes, it looks like they did release 6.1.7.7 temporally subsequent to that discussion, but looking at a file like rescuable.rb, Rails 6.1.7.7 doesn't include include the code from the fix, so one has to figure out how to adapt their Gemfile to point to the Rails 6-1-stable branch No releases have happened after 6.1.7.7: |
Oh bummer! I misread the version list. |
@bensheldon We are looking to migrate from DelayedJob to GoodJob. We are running Rails 6.1 / Ruby 3.2. Is there a recommended path forward to resolved this compatibility issue? I attempted pulling rails from the 6-1-stable branch but that didn't seem to work either. Thanks for your efforts here. |
@pattersonc that's a bummer 😞 Also strange that's it's not working even when you directly use the branch, I'm assuming via something like this: https://github.com/samvera/hyku/pull/2125/files It's a bit of a bind because I won't change those method signatures without a major version deprecation cycle. Are you able to update Rails to a more recent version while still staying on Delayed Job, and then migrate to GoodJob? |
@bensheldon My issue was unrelated. I had an older version of |
Good job stopped working after valkyrizing adventist. issue - bensheldon/good_job#1280 solution - samvera/hyku#2125
Hey @bensheldon, long time supporter of the project 👋 Thanks for all the great work you've done over the last couple years since I first subscribed.
Today I upgraded my Rails site that uses good_job to Ruby 3.2 (I am on Rails 6.1.7.7), and I used the upgrading occasion to upgrade my good_job from 2.7.4 to 3.26.1. Unfortunately, now when I run
rails s
, I get an endless loop of failure that prevents me from using my app:I've attached a file that shows the full output of starting my development server.
After the screenshot, the message just repeats in an endless loop several times per second.
I took a look at the code in question:
But it's not clear to me where the exception is coming from, or what aspect of the Rails startup process is triggering the exception, but I can't claim to understand the answer to either Q. Hopefully you have ideas, such that I can run my project again soon? I would normally try to move back to older gem versions to diagnose what version this started at, but part of my upgrade process was that good_job generated ~10 new migration files that I ran, which gives me the impression that if I tried to move to an older gem version, I would probably generate errors from schema mismatch, so I'm kind of at a dead end on how I might proceed. Thanks for any help!
The text was updated successfully, but these errors were encountered: