Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined method unhandled_error for nil #1485

Closed
coorasse opened this issue Sep 12, 2024 · 3 comments · Fixed by #1486
Closed

Undefined method unhandled_error for nil #1485

coorasse opened this issue Sep 12, 2024 · 3 comments · Fixed by #1486

Comments

@coorasse
Copy link

coorasse commented Sep 12, 2024 •
edited
Loading

See the following:
CleanShot 2024-09-12 at 10 12 27@2x

This errors is happening when using an inline adapter. I am not sure how result can be nil, but I happy to provide more information.

GoodJob version: 4.2.1
Rails version: 7.1.4
Ruby version 3.3.5
@Earlopain
Copy link
Collaborator

Looks like something outside of the job itself is raising with then causes the result to be nil, and the ensure itself raising shadows the actual error.

Can you make the following edit? 2921c44 bundle open good_job will help. This should show what is actually going wrong here

@coorasse
Copy link
Author

Yes, with this change I can now see the original error 👍
CleanShot 2024-09-12 at 14 49 41@2x

Earlopain added a commit to Earlopain/good_job that referenced this issue Sep 12, 2024
@Earlopain
Handle gem loading errors in perform_inline
f8d4f90 
`Gem::LoadError` does not inherit from `StandardError` and as such won't be rescued.
Just let it bubble up.

Closes bensheldon#1485
Earlopain added a commit to Earlopain/good_job that referenced this issue Sep 12, 2024
@Earlopain
Handle gem loading errors in perform_inline
9ef82bb 
`Gem::LoadError` does not inherit from `StandardError` and as such won't be rescued.
Just let it bubble up.

Closes bensheldon#1485
@Earlopain Earlopain mentioned this issue Sep 12, 2024
Merged
@Earlopain
Copy link
Collaborator

Right, so I guess your job creates an attachment somewhere, and that attachment has some variant(s). That functionality does require this gem and it autoloaded only once actually accessed.

I openend #1486 to show the proper error message by default.

Earlopain added a commit to Earlopain/good_job that referenced this issue Sep 12, 2024
@Earlopain
Handle gem loading errors in perform_inline
70d729b 
`Gem::LoadError` does not inherit from `StandardError` and as such won't be rescued.
Just let it bubble up.

Closes bensheldon#1485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't shadow gem loading errors during autoloading with the inline adapter Earlopain/good_job
2 participants
@coorasse @Earlopain