Migrations generator assumes migrations are in db/migrate

[zachmargolis]

tl;dr

Would like bin/rails g good_job:update to allow us to specify a separate DB or separate migrations directory, like the --database option in rails generate migration

Background

In our app, we have set up the good_jobs table in a separate database from our main application.

Per the ActiveRecord multiple databases guide, we use the migrations_paths config to put those migrations are in db/worker_jobs_migrate instead of the normal db/migrate.

When generating migrations, we use the --database CLI arg to specify worker_jobs so Rails knows to put things in the right spot, ex:

bin/rails generate migration CreateDogs name:string --database worker_jobs

However, GoodJob assumes migrations are in db/migrate:

good_job/lib/generators/good_job/update_generator.rb

Line 26 in 236aea2

migration_template "migrations/#{template_file}", "db/migrate/#{destination_file}", skip: true

Problems

Since our migrations are in a different place, GoodJob is unable to detect migrations that have already happened to give us diffs

[zachmargolis]

Also, slightly related:

good_job/spec/test_app/db/migrate/20210623192051_add_active_job_id_index_and_concurrency_key_index_to_good_jobs.rb

Lines 6 to 8 in a69de2e

	class GoodJobJobs < ActiveRecord::Base
	self.table_name = "good_jobs"
	end

I can't tell exactly where this comes from, but inside the migrations they create a model that inherits from ActiveRecord::Base to do a migration but we'd need ours to come from GoodJob.active_record_parent_class instead for similar reasons

[bensheldon]

Oh! Both of these are unfortunate.

I will see if there is a simple way to pass down the options flag. I have regrets not using the default Rails::Engine mechanism for generating database migrations (I only recently learned about that).

And thank you for flagging the ideal base class in the migration; that's a quick fix.

[bensheldon]

Released in v1.99.1 and v2.0.2. Thank you!

[zachmargolis]

Such a fast turnaround! Thank you! 🙌 😍