dashboard/engine – i18n: Wrong translation scope

[Jay-Schneider]

Hi there,

I encountered a problem when updating good_job from 2.14.2 to 2.15.0 regarding the hereby introduced internationalization.

The application I am running is configured to raise an exception instead of falling back to display the key in question.
When I visit the dashboard I receive a I18n::MissingTranslationData in GoodJob::Jobs#index stating translation missing: en.status.scheduled.

I figured out that this is actually a problem in the gem, where the view refers to scope: '.status' while the locale file actually has the translations nested under good_job.status (which might be the better choice here imho).

good_job/engine/app/views/good_job/shared/_filter.erb

Lines 10 to 13 in 265f5bf

	<% filter.states.each do |name, count| %>
	<li class="nav-item">
	<%= link_to url_for({state: name}), class: "nav-link #{"active" if params[:state] == name}" do %>
	<%= t(name, scope: '.status') %>

good_job/engine/config/locales/en.yml

Lines 48 to 65 in 265f5bf

	good_job:
	shared:
	footer:
	last_update_html: Last updated <time id="page-updated-at" datetime="%{time}">%{time}</time>
	wording: Remember, you're doing a Good Job too!
	navbar:
	cron_schedules: Cron
	jobs: Jobs
	live_poll: Live Poll
	name: "GoodJob 👍"
	processes: Processes
	status:
	discarded: Discarded
	finished: Finished
	queued: Queued
	retried: Retried
	running: Running
	scheduled: Scheduled

So maybe the fix just constists of adjusting to scope to .goodjob.status?

Additionally one might consider configuring i18n to raise during tests so that such mistakes are not concealed.

Best regards 👋

[bensheldon]

@Jay-Schneider thanks for reporting this! You're correct, the scope should be good_job.status and that's a good suggestion to set the GoodJob test environment to raise on missing translations. Can you make a PR for that? (I see you have a commit already)

[bensheldon]

@Jay-Schneider This has been released in v2.5.1