Fix bulk enqueue for unmigrated 'error_event'; add GoodJob.migrated? check method; use custom enum implementation
#1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
migrated_check
branch
5 times, most recently
from
dc8bb86
to
4f7cf8a
Compare
bensheldon
changed the title
GoodJob.migrated? check methodGoodJob.migrated? check method; use custom enum implementation
bensheldon
force-pushed
the
migrated_check
branch
5 times, most recently
from
8587faf
to
d217a3e
Compare
…` check method; use custom enum implementation
bensheldon
force-pushed
the
migrated_check
branch
from
d217a3e
to
088f31b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1010
It's not possible to use the Rails
enumbecause Rails 7.1a introduces a validation check that the column exists: rails/rails#45734