Fix NoMethodError: undefined method `silence' for nil:NilClass #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't attempt to call logger.silence if ActiveRecord::Base.logger is nil. Fixes bensheldon#1036.
bensheldon
reviewed
Aug 10, 2023
There was a problem hiding this comment.
@afn for some reason I'm having trouble pushing into your branch, but to solve Sorbet, run:
bin/tapioca todo and then run bin/lint again and you should be golden. Thank you!
|
Done - thanks for the quick reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't attempt to call
logger.silenceif ActiveRecord::Base.logger isnil.
Fixes #1036.