New probe server fixes: allow accept_nonblock to raise and IO.gets return nil #1043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of suggested fixes for the new probe http server. Commits should be self-explanatory, still some more context below.
Passing
exceptions: false
no longer raisesIO::WaitReadable
leaving the server in an unknown state.An
IO.gets
returns either a string or a nil. A nil response from a socket was not handled, suggesting we just skip those.Appreciate taking a look as we're affected by these issues.