GoodJob.restart
should not start capsules (job execution) when in a webserver but not in async mode
#1055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1054
This isn't my favorite, but the docs have been telling people forever to use this pattern and there isn't a simple way to fix #1054 while also not requiring everyone to change their configuration.
If this causes problems, I imagine that I'll add something like
restart!
that will ignore the new check (or introduce a simpler "start", or ensure that "restart" doesn't actually start the capsule if it hadn't previously been running but rather just return it to the same state). But I am not aware of anyone manually creating capsules, so it's likely not used.