Address rails 7.1 deprecation when using ActiveJobExtensions::Concurrency
#1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
rails-7.1-deprecation
branch
from
45b02f3
to
8a5304c
Compare
mhenrixon
approved these changes
Oct 3, 2023
bkeepers
approved these changes
Oct 3, 2023
|
thank you! |
|
Just a note, rc (and probably beta) versions don't match like this. The deprecation warning will stop triggering once a non-preview version of rails is released. |
|
@Earlopain oh, we should fix that. There's a version matcher that will include RC versions, I just need to find/remember what it is. |
|
My bad, I wasn't aware about that functionality. As per the docs appending |
|
Thanks! I'll make that change on |
|
Hey @bensheldon I see you’ve released 3.19.4 but the latest version released on rubygems.org is 3.19.3. Could you push 3.19.4 to rubygems.org? |
|
Oops! Sorry about that! I just pushed the gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1096, it's a simple fix so why not do it myself.
There are still a few references to exponentially_longer in the readme but it didn't seem wise to change those while it's not actually usable. I did change one instance in the readme where it explains what it does, since it's not actually exponetially longer but if you think that's just going to cause confusion I'll just drop that.