Always instantiate MultiScheduler; delegate Scheduler Metrics to JobPerformer #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
changed the title
bensheldon
force-pushed
the
refactor_counts
branch
from
9409539
to
4061603
Compare
bensheldon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always instantiates a MultiScheduler, even if there is configured only a single thread pool.
Moves the Metrics into the JobPerformer, which is intended to be aware of jobs and their meaning. My vision for the Scheduler is that it should be largely ignorant/generic of what it executes or the result, but that vision has slipped; this tries to move it back in that direction. This also adds a few more metrics, tracking:
queue_check_at: the last time the queue was checked for jobsexecution_at: the last time a execution/job was dequeued or finished(These are in support of #1146)
And removes
unexecutable_executions_countbecause I think it wasn't tracking anything.